Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: file-roller https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225751 bdpepple@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bdpepple@xxxxxxxxxxxxx |caillon@xxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2007-02-03 13:07 EST ------- Good: * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Package builds in Mock. Must Fix: * Source URL in not canonical * Remove unnecessary Requires: Requires(post): desktop-file-utils Requires(postun): desktop-file-utils Refer to: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef Minor: * Duplicate BuildRequires: glib2-devel (by pango-devel), pango-devel (by gtk2-devel), gtk2-devel (by libgnomeui-devel), libgnomeprint22-devel (by libgnomeprintui22-devel), autoconf (by libtool) * Could use -disable-static and not bother building static libs. * It looks like the Requires on GConf is unnecessary. * Is the conflicts on nautilus still necessary? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review