[Bug 815814] Review Request: rubygem-paranoia - Cleaner re-implementation of acts_as_paranoid (ActiveRecord soft-delete plugin)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815814

--- Comment #22 from Steve Linabery <slinaber@xxxxxxxxxx> 2012-04-30 17:55:22 EDT ---
(In reply to comment #21)
(snip)
> [NOT OK] MUST: The package must provide rubygem(%{gemname}) where gemname is
>          the name from the Gem's specification. For every dependency on a Gem
> named
>          gemdep, the package must contain a Requires on rubygem(%{gemdep}) with
> the same
>          version constraints as the Gem
> 
>     I'm no ruby expert but I don't see the rubygemrubygem(%{gemdep}).
>     Am I simply missing something?
> 

I think you are just missing something. For example:
Requires: rubygem(activerecord) >= 3.0.0

> [NOT OK] MUST: The Gem must be installed into %{gemdir} defined as "%global
>          gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)"
> 
>     Again I'm no ruby expert but I don't see the gemdir...
>     Am I simply missing something?
> 

See comment #13. I think this checklist is based on the <=f16 macro
definitions.

> [NOT OK] MUST: The package must own the following files and directories:
>            %{gemdir}/gems/%{gemname}-%{version}/
>            %{gemdir}/cache/%{gemname}-%{version}.gem
>            %{gemdir}/specifications/%{gemname}-%{version}.gemspec
> 
>     Again I'm no ruby expert but I don't see the gemdir...
>     Am I simply missing something?
> 

$ rpm -q --filesbypkg -p rubygem-paranoia-1.1.0-3.fc18.noarch.rpm 
rubygem-paranoia          /usr/share/gems/gems/paranoia-1.1.0
rubygem-paranoia          /usr/share/gems/gems/paranoia-1.1.0/README.md
rubygem-paranoia          /usr/share/gems/gems/paranoia-1.1.0/lib
rubygem-paranoia          /usr/share/gems/gems/paranoia-1.1.0/lib/paranoia
rubygem-paranoia          /usr/share/gems/gems/paranoia-1.1.0/lib/paranoia.rb
rubygem-paranoia         
/usr/share/gems/gems/paranoia-1.1.0/lib/paranoia/version.rb
rubygem-paranoia          /usr/share/gems/specifications/paranoia-1.1.0.gemspec

It's all there except for cache. Not sure if that is no longer required.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]