[Bug 815814] Review Request: rubygem-paranoia - Cleaner re-implementation of acts_as_paranoid (ActiveRecord soft-delete plugin)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815814

--- Comment #21 from Joe VLcek <JVLcek@xxxxxxxxxx> 2012-04-30 16:31:07 EDT ---
There are what may be a couple of issue. Please see the ones I have marked
[NOT OK]. These my be easily explainable and simply because I am no ruby
expert.

Please reply with reasoning or address accordingly.

Thanks. Joe


== RUBY requirements ==

From: http://fedoraproject.org/wiki/Packaging:Ruby

[  OK  ] MUST: Packages that contain Ruby Gems must be called
rubygem-%{gem_name}. 

[  OK  ] MUST: The name of a ruby extension/library package must be of the
         form ruby-UPSTREAM

[  NA  ] MUST: A ruby extension/library package must indicate what it provides
         with a Provides: ruby(LIBRARY) = VERSION declaration in the spec file

[  OK  ] MUST: Pure Ruby packages must be built as noarch packages.

[  NA  ] MUST: The Ruby library files in a pure Ruby package must be placed
         into Config::CONFIG["sitelibdir"] . The specfile must get that path
         using %{!?ruby_sitelib: %global ruby_sitelib %(ruby -rrbconfig -e
         'puts Config::CONFIG["sitelibdir"] ')}

[  NA  ] MUST: For packages with binary content, e.g., database drivers or any
         other Ruby bindings to C libraries, the package must be architecture
         specific.

[  NA  ] MUST: The binary files in a Ruby package with binary content must be
         placed into Config::CONFIG["sitearchdir"]

[  OK  ] MUST: Packages that contain Ruby Gems must be called
         rubygem-%{gemname} where gemname is the name from the Gem's
specification.

[  OK  ] MUST: The Source of the package must be the full URL to the released
         Gem archive; the version of the package must be the Gem's version

[  OK  ] MUST: The package must have a Requires and a BuildRequires on
         rubygems

[NOT OK] MUST: The package must provide rubygem(%{gemname}) where gemname is
         the name from the Gem's specification. For every dependency on a Gem
named
         gemdep, the package must contain a Requires on rubygem(%{gemdep}) with
the same
         version constraints as the Gem

    I'm no ruby expert but I don't see the rubygemrubygem(%{gemdep}).
    Am I simply missing something?

[NOT OK] MUST: The Gem must be installed into %{gemdir} defined as "%global
         gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)"

    Again I'm no ruby expert but I don't see the gemdir...
    Am I simply missing something?

[NOT OK] MUST: The package must own the following files and directories:
           %{gemdir}/gems/%{gemname}-%{version}/
           %{gemdir}/cache/%{gemname}-%{version}.gem
           %{gemdir}/specifications/%{gemname}-%{version}.gemspec

    Again I'm no ruby expert but I don't see the gemdir...
    Am I simply missing something?

[  OK  ] MUST: Architecture-specific content must not be installed into
%{gemdir}

[  OK  ] MUST: If the Gem only contains pure Ruby code, it must be marked as
         BuildArch: noarch. If the Gem contains binary content (e.g., for a
database
         driver), it must be marked as architecture specific, and all
architecture
         specific content must be moved from the %{gemdir} to the
[#ruby_sitearch
         %{ruby_sitearch} directory] during %install

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]