[Bug 814887] Review Request: encuentro - Content visualization of the Canal Encuentro.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=814887

--- Comment #18 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2012-04-26 11:25:57 EDT ---
FIXED:
* Builds in koji:
/srv/git/wishlist/encuentro-0.5-5.fc16.src/encuentro-0.5-5.fc16.src.rpm
* Some of the rpmlint complaints
* Built rpm installs and runs

NEEDS FIXING:
* We're not shipping apport in Fedora so we shouldn't be shipping the apport
  files.  You can delete them in the %install section or use %exclude in the
files section to deal with it.  (For instance:

  %files
  %exclude %{_datadir}/apport/

* Description (and changelog) lines should be no more than 80 characters

rpmlint still complains:
- encuentro.noarch: W: name-repeated-in-summary C Encuentro
  Is Canal Encuentro the proper name of a "place"/project/similar?  If so, this
  warning can be ignored.  If not, it shouldn't be in the Summary.  I don't
  know which it is.
- encuentro.noarch: E: description-line-too-long C This is a simple program to
search, download and see the content of the Canal Encuentro.
  Lines should be less than 80 characters.  So you should go through your
  desciption and split all lines that are over 80 characters with newlines
- encuentro.noarch: W: no-manual-page-for-binary encuentro
  This is a warning that there's no man page.  If one exists somewhere (for
  instance in the Debian package) you can include it in our package.  If you've
  looked and haven't found a man page elsewhere, just state that you couldn't
  find one.
* encuentro.spec:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line
1)
  This is cosmetic but ought to be cleaned up.  Some of your lines have both
  spaces and tabs to format them.  It's better to just use spaces or just tabs.
  I personally prefer all spaces.  There's also  trailing tabs in some of your
  lines (Look at Version for instance).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]