Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=735160 --- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2012-04-25 20:15:03 EDT --- Unless you're packaging for EL5, you don't need to clean out the buildroot at the beginning of %install. You also don't need a BuildRoot: line, or a %clean section if you're not targeting EL5. http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag and http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines have the details. No (supported) release of EPEL or Fedora needs the %defattr line. Maybe EL4 needed it but that's EOL now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review