Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810676 --- Comment #7 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> 2012-04-25 17:38:24 EDT --- I found a few more small problems: You don't use chrpath, and indeed it doesn't seem to be needed, so the dependency on it should be removed. Please use cp --preserve=timestamps in the makefile, or simply cp -a, to preserve the timestamps on installed source files and documents. %defattr is unnecessary with current RPM versions, but it's not forbidden so you can keep it if you want. I think AUTHORS should go in the base package. Information about who the authors are is logically connected with the license file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review