Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789240 --- Comment #1 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2012-04-24 10:34:00 EDT --- - Desktop file: * Key "Categories" is a list and does not have a semicolon as trailing character. * Value "freqtweak.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path - Source URL: md5sum doesn't match. for sourceforge.net see: https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net - SourceX and PatchY should be prefixed with %{name} and %{name}-%{version} where applicable. - Patches should have a bug report. - You should open a bug about incorrect FSF postal address in license and code files. - Non a blocker, but it will be interesting to make this patch suitable to all platforms: freqtweak.spec: W: %ifarch-applied-patch Patch1: freqtweak-0.7.2-long.patch A patch is applied inside an %ifarch block. Patches must be applied on all architectures and may contain necessary configure and/or code patch to be effective only on a given arch. Rpmlint output: SPECS/freqtweak.spec: W: %ifarch-applied-patch Patch1: freqtweak-0.7.2-long.patch freqtweak.x86_64: W: spelling-error Summary(en_US) Realtime -> Mealtime, Real time, Real-time freqtweak.x86_64: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time freqtweak.x86_64: W: spelling-error %description -l en_US spectragrams -> spectra grams, spectra-grams, pentagrams freqtweak.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee freqtweak.x86_64: E: incorrect-fsf-address /usr/share/doc/freqtweak-0.7.2/COPYING freqtweak.x86_64: W: manual-page-warning /usr/share/man/man1/freqtweak.1.gz 148: warning: macro `T' not defined freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocBoost.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorGui.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/slider_bar.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTutils.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTportSelectionDialog.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTspectragram.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocPitch.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTportSelectionDialog.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocI.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTutils.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocCompressor.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTapp.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocLimit.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocDelay.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocCompressor.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTspectralEngine.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocDelay.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTtypes.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodRotate.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/pix_button.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/spin_box.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/slider_bar.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTspectralEngine.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocOrderDialog.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodValueLFO.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocOrderDialog.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/pix_button.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocessPath.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodRotate.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocWarp.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorDialog.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodRotateLFO.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorGui.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTpresetBlender.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/spin_box.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTjackSupport.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorDialog.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTconfigManager.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocGate.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodRandomize.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocBoost.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmainwin.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTapp.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTconfigManager.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTdspManager.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmainwin.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocWarp.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTjackSupport.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FThelpWindow.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorI.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocLimit.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocI.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorI.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FThelpWindow.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTactiveBarGraph.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTspectrumModifier.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodValueLFO.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/LockMonitor.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTdspManager.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocEQ.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodRotateLFO.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocEQ.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/RingBuffer.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocessPath.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTspectragram.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTpresetBlendDialog.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorManager.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocPitch.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTpresetBlender.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTspectrumModifier.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/RingBuffer.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTioSupport.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTupdateToken.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTactiveBarGraph.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodulatorManager.cpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTprocGate.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTioSupport.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTmodRandomize.hpp freqtweak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/freqtweak-0.7.2/src/FTpresetBlendDialog.cpp freqtweak.src: W: spelling-error Summary(en_US) Realtime -> Mealtime, Real time, Real-time freqtweak.src: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time freqtweak.src: W: spelling-error %description -l en_US spectragrams -> spectra grams, spectra-grams, pentagrams freqtweak.src: W: spelling-error %description -l en_US pre -> per, ore, pee freqtweak.src: W: %ifarch-applied-patch Patch1: freqtweak-0.7.2-long.patch freqtweak.src: W: file-size-mismatch freqtweak-0.7.2.tar.gz = 239792, http://dl.sf.net/sourceforge/freqtweak/freqtweak-0.7.2.tar.gz = 54081 3 packages and 1 specfiles checked; 80 errors, 12 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review