Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809086 --- Comment #3 from Michael Schwendt <mschwendt@xxxxxxxxx> 2012-04-24 10:35:21 EDT --- True. I didn't spot any of the maths for decoding the audio data either. Just the parsing of the file format to find frames. [...] Other than that, skimming over the file, I see several items that are unusual (and not typical for Fedora packages). Such as, but possibly not limited to: > License: GPL GPLv2+ according to the source files. > BuildRoot: %{_tmppath}/build-%{name}-%{version} Please consult the related section in the packaging guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines > BuildRequires: gcc-c++ libstdc++ libstdc++-devel glibc-devel These are all not needed, https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 and make it less easy to rebuild packages in an environment with a replaced minimum build environment. > %build > cd %{_builddir}/%{name}-%{version}-src This 'cd' command is not needed, because the source code's top-level directory is entered automatically. Verify by taking a look at the rpmbuild output. > %clean > %{__rm} -rf "%{buildroot}" > %files > %defattr(-,root,root) > Source: http://prdownloads.sourceforge.net/mp3val/%{name}-%{version}-src.tar.gz There's a section in the packaging guidelines about these items. [...] Visiting the Fedora Packaging related Wiki pages is highly recommended. https://fedoraproject.org/wiki/PackageMaintainers The Review Guidelines are not just for reviewers, but for package submitters and existing packagers, too: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review