Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811418 --- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> 2012-04-24 02:11:20 EDT --- Ok, the specfile looks much better now, just a few catches: - If you want to build in EPEL as well, you have to define the macros in the way they used to be defined in the previous packaging guidelines [1]. - Also, you have to conditionally require rubygems-devel or rubygems, depending on if you are in Fedora or in EPEL. - A better way to make files executable is to run chmod in %install. Notice, that the way you are doing it now causes the rpmbuild to complain: warning: File listed twice: /usr/share/gems/gems/hydra-0.24.0/test/fixtures/hello_world.rb warning: File listed twice: /usr/share/gems/gems/hydra-0.24.0/test/fixtures/many_outputs_to_console.rb - As for the wrong EOF encodings, these are standard rpmlint warnings when packaging gems with ri/rdoc, you don't have to worry about them. [1] https://fedoraproject.org/wiki/Packaging:Old_Ruby -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review