Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811418 --- Comment #2 from Matt Hicks <mhicks@xxxxxxxxxx> 2012-04-23 10:31:50 EDT --- Thanks for the review! I've updated the following here: Spec URL: http://matthicksj.fedorapeople.org/reviews/rubygem-hydra.spec SRPM URL: http://matthicksj.fedorapeople.org/reviews/rubygem-hydra-0.24.0-1.fc16.src.rpm I couldn't find a good example in the packaging guidelines of how to properly do the macros properly for EPEL - if you have an example, I'd be happy to add that, otherwise, getting into Fedora is probably a good start. I made the following changes: - Removed .document from the builddir - Added %doc to TODO and %{docdir} - Set 755 to the test scripts Around the tests, I hit the same problem there, so they aren't running. Also, I went back and forth about running sed to remove some of the rpmlint warnings on the wrong-file-end-of-line-encoding (see [1]) but saw some discussion about that potentially breaking things (see [2]) and decided not to. Any suggestions there? [1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding [2] https://bugzilla.redhat.com/show_bug.cgi?id=728256 Thanks again -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review