[Bug 812561] Review Request: python-ipdb - IPython enabled Python debugger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=812561

--- Comment #5 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2012-04-22 12:08:07 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > This means you are shipping an unreleased version and therefore need the proper
> > pre-release naming convention:
> > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
> 
> I'm not sure I know what you mean here. Should I change the Release to be:
> 
> Release:        0.2.dev.%{checkout}%{?dist}

A "Release: $number" refers to a proper released version of the package and
  "Release: 0.$number" means, it is a pre-release version.

So it looks from the package version, that you packaged 0.7, which is not
released yet and therefore needs an "0." in the Release macro.

> Having dev and the checkout info seems redundant to me, but after rereading the
> naming guidelines I guess that's the most correct way to do it.

/me too. I'd left "dev" out of the release:
Release:    0.2.${date}git%{?dist}
or
Release:    0.2.${date}git${commitid}%{?dist}

> > 
> > 
> > Why aren't you using the released 0.6.2?
> > It seems run{,call,eval} and the python3 support are new since then.
> > 
> 
> I wanted to use the most recent version available, 0.6.1 was released in
> 10/2011 (I assume you mean 0.6.1, as there is no 0.6.2).

Yes, sure...

> > 
> > It would be great to ask upstream, what license exactly is meant with GPL as
> > "GPL" seems to be bad:
> > http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL
> > 
> > As upstream doesn't add a LICENSE/COPYING file, it's a SHOULD anyway to ask
> > them to add one...
> 
> I'll see if upstream will add this and clarify the license.

Great. Most likely they mean GPLv2+ with it, but maybe only GPLv2...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]