Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814916 Orcan Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |814542 --- Comment #5 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2012-04-22 11:43:11 EDT --- I made a full review on this, but I see that Mattias is already assigned to the bug. I'll post my findings anyways: ! rpmlint says: sratom.x86_64: W: spelling-error %description -l en_US serialisation -> serialization, sensationalist, sensationalism sratom.x86_64: W: spelling-error %description -l en_US serialise -> serialize, serial, aerialist sratom.src: W: spelling-error Summary(en_US) serialising -> serializing, serialization There was a requirement that says the spec file must be written in American English, so I guess we should use serializ* * Need to add BuildRequires: serd-devel >= 0.14.0 Other than the above, the package is good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review