Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=782560 --- Comment #30 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-04-20 04:06:49 EDT --- Hi Todd, (In reply to comment #29) > I spent time over the past few days adding support for gem_extdir on Fedora >= > 17. An update spec file is now in place: > > http://tmz.fedorapeople.org/specs/rubygem-ruby-shadow.spec Thank you Todd. I have a few notes: * The EPEL section is wrong. It has to follow the old guidelines (hm, they are lost somewhere :/ [1]), so you should update the %{gem_dir} macro: %global gem_dir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) The rest is OK. * Detecting version of Ruby is not good practice IMO. What if you have installed by a chance older version of Ruby on your system and later you will produce unexpected packages? I know, it will never happen on build system, but might bite somebody when rebuilding locally. * The linking of *.so for Fedoras < 17 and EPEL is wrong. Actually there should be no linking at all. You should move the library into the sitearch dir: mv %{buildroot}%{gem_libdir}/shadow.so %{buildroot}%{ruby_sitearch}/shadow.so The approach is the same for all mentioned versions. > As far as adding a comment about the licensing, would it suffice to link to the > original ruby-shadow review? This code has not changed since then as far as > the licensing, so I don't think there's any reason to try and chase down the > original authors for a statement. Well, as far as I am looking into the original review, there were also uncertainties about licensing which were never clarified. Also, the reviewer guidelines contains this line: SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. So I would appreciate if you can ask upstream about the license. > > With respect to Fedora 15/16 support, I thought that they were supposed to have > backported support in ruby/irb/rubygems so that installing to the gemdir would > allow the module to be used from ruby? This does not work for me: > > [root@f16-32 /]# cat /etc/redhat-release > Fedora release 16 (Verne) > [root@f16-32 /]# rpm -qa ruby\* > rubygems-1.8.11-1.fc16.1.noarch > ruby-libs-1.8.7.358-1.fc16.i686 > ruby-irb-1.8.7.358-1.fc16.noarch > rubygem-ruby-shadow-2.1.3-2.fc16.i686 > ruby-1.8.7.358-1.fc16.i686 > ruby-rdoc-1.8.7.358-1.fc16.noarch > [root@f16-32 /]# irb > irb(main):001:0> require 'shadow' > LoadError: no such file to load -- shadow > from (irb):1:in `require' > from (irb):1 > from :0 You have forgotten one important thing: require 'rubygems' , since rubygems were not loaded by default in Ruby 1.8. Also 'gem list' is useful command for basic check if gem is installed and recognized by RubyGems. [1] https://fedorahosted.org/fpc/ticket/165 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review