Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808881 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> 2012-04-19 10:52:21 EDT --- Review for perl-MetaCPAN-API ============================ - rpmlint clean - package and spec file naming OK - package meets guidelines - license is OK for Fedora, matches upstream, and LICENSE file is packaged - spec file written in English and is legible - source tarball matches upstream - package builds OK in mock for F-16..F-18 (x86_64 [noarch]) - package tested and works OK in F-16 x86_64 - --with network-tests build option works as advertised - buildreqs sufficient and not redundant - no locales, libraries, devel files to worry about - not intended to be relocatable - no duplicate files or directory ownership issues - permissions sane - macro usage is consistent - code, not content - no large docs to consider - docs don't affect runtime - not a GUI app, no .desktop file needed - all filenames are plain ASCII - no scriptlets present or needed - no file dependencies Requires -------- perl(:MODULE_COMPAT_5.14.2) perl(Any::Moose) perl(Carp) perl(HTTP::Tiny) perl(JSON) perl(Try::Tiny) perl(URI::Escape) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Provides -------- perl(MetaCPAN::API) = 0.43 perl(MetaCPAN::API::Author) = 0.43 perl(MetaCPAN::API::Module) = 0.43 perl(MetaCPAN::API::POD) = 0.43 perl(MetaCPAN::API::Release) = 0.43 perl(MetaCPAN::API::Source) = 0.43 perl-MetaCPAN-API = 0.43-1.fc18 Nothing to quibble about here. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review