Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812674 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #12 from Richard Shaw <hobbes1069@xxxxxxxxx> 2012-04-19 10:32:40 EDT --- Ok, I have one minor optional nit-pick. It's kind of stupid but the freedesktop spec indirectly requires at least a 48x48 icon file even if you have an SVG. This package only provides up to a 32x32. You could ask upstream or use imagemagick convert to create one of the SVG. I've done this on the fly in the spec file for previous packages but then you have the extra BRs of ImageMagick. +: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output: shown in comment. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: GPLv2+ [+] license field matches the actual license. [+] license file is included in %doc: COPYING [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum matches (18b97581aee0d297d9ec5df60b550dc6) [+] package builds on at least one primary arch: Tested F16/17 x86_64 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [+] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [+] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [+] query upstream for license text [N] description and summary contains available translations [+] package builds in mock [+] package builds on all supported arches: Tested x86_64 [?] package functions as described: Not tested [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [+] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review