Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738556 --- Comment #34 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2012-04-16 16:07:12 EDT --- (In reply to comment #33) I have fixed the problems you found, here is the new version: Spec file: https://raw.github.com/jorti/gogoc-fedora-package/v1.2-15/SPECS/gogoc.spec SRPM file: https://github.com/jorti/gogoc-fedora-package/raw/v1.2-15/SRPMS/gogoc-1.2-15.fc16.src.rpm Rpmlint output explained: gogoc.x86_64: E: non-readable /etc/gogoc/gogoc.conf 0640L - This file contains passwords, so it must be non world readable. gogoc.x86_64: E: non-executable-script /etc/gogoc/template/linux.sh 0644L /bin/sh - Not needed, it's called by the shell: /bin/sh /etc/gogoc/template/linux.sh gogoc.x86_64: W: log-files-without-logrotate /var/log/gogoc - The daemon does its own configurable log rotation gogoc-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gogoc-1_2-RELEASE/gogoc-tsp/include/net_tcp6.h gogoc-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gogoc-1_2-RELEASE/gogoc-tsp/src/net/net_tcp6.c - Upstream is notified of this. 3 packages and 1 specfiles checked; 4 errors, 1 warnings. > > * This code is missing a copy of the GPLv2 license text. Not a packaging > blocker, but you should be sure to inform upstream and ask them to add a copy > of that license text in the source tree. Upstream don't have a public bug tracker, I have submitted to them all patches by email, I'll notify them about this missing license. > > * The package contains two copies of an identical file: > > /etc/gogoc/template/linux.sh > /usr/share/gogoc/template/linux.sh I have removed all the /usr/share/gogoc directory, because only the one in etc is used. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review