Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810676 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |bjorn@xxxxxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |bjorn@xxxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> 2012-04-09 07:34:52 EDT --- This is what I see at first glance: · The license differs between the main package and the -devel subpackage. Is that really true? If not, please remove the license field from the subpackage. · The -devel subpackage lacks a dependency on fedora-gnat-project-common. · The version field says 2.10.0 but in the changelog it says 2.8.0. · I think the URL field should point to a page that describes AWS, that is http://libre.adacore.com/libre/tools/AWS/ instead of Adacore's front page. · According to the copyright notices in aws.gpr and template_parser.gpr those files were written by Adacore. Is that true? If so, why are they in aws-fedora.tgz and not in aws-gpl-2.10.0-src.tgz? I'll have a closer look later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review