Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810010 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx --- Comment #2 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2012-04-07 19:27:58 EDT --- For more information on how to get sponsored see: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Did you already do some informal reviews? Could you link them here, please? The general guidelines are at: http://fedoraproject.org/wiki/Packaging:Guidelines As you are using python and perl, this also applies: http://fedoraproject.org/wiki/Packaging:Python http://fedoraproject.org/wiki/Packaging:Perl First iteration of blocker issues: - use a full url, that is wget'able: http://fedoraproject.org/wiki/Packaging:SourceURL - Please include the manpage as genders.3.* and not as genders.3.gz, so the compression format can change at any time - *.la should be removed, whenever possible... - When you really want to package the static libraries, they need to have it's own -static package. In corner cases -static and -devel is the same package, but only, when there are no shared libraries included: http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries - Please use parallel make: http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - Be more specific in python %files and use %{python_sitearch}, e.g. %{python_sitearch}/%{name}.py* %{python_sitearch}/lib%{name}.so %{python_sitearch}/lib%{name}-*egg-info - Always add a changelog entry to the footer and bump the release when you do changes (and describe them in the changelog entry) - Further rpmlint issues: $ rpmlint /home/tom/rpmbuild/SRPMS/genders-1.18-1.fc16.src.rpm /home/tom/rpmbuild/RPMS/x86_64/genders-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/genders-compat-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/genders-perl-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/genders-python-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/libgenders-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/libgenders-devel-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/libgendersplusplus-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/libgendersplusplus-devel-1.18-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/genders-debuginfo-1.18-1.fc16.x86_64.rpm genders.src: W: summary-ended-with-dot C Static cluster configuration database. genders.src: E: no-changelogname-tag genders.src: W: invalid-license GPL genders.src:78: W: rpm-buildroot-usage %build --with-extension-destdir="$RPM_BUILD_ROOT" genders.src:129: E: hardcoded-library-path in %{_prefix}/lib/genders/* genders.src: W: invalid-url Source0: genders-1.18.tar.gz genders.x86_64: W: summary-ended-with-dot C Static cluster configuration database. genders.x86_64: E: no-changelogname-tag genders.x86_64: W: invalid-license GPL genders-compat.x86_64: W: spelling-error Summary(en_US) compatability -> comparability, compatibility, communicability genders-compat.x86_64: W: summary-not-capitalized C compatability library genders-compat.x86_64: E: no-changelogname-tag genders-compat.x86_64: W: invalid-license GPL genders-compat.x86_64: W: only-non-binary-in-usr-lib genders-compat.x86_64: E: script-without-shebang /usr/lib/genders/hostlist.pl genders-compat.x86_64: E: script-without-shebang /usr/lib/genders/gendlib.pl genders-perl.x86_64: W: summary-not-capitalized C perl libraries genders-perl.x86_64: E: no-changelogname-tag genders-perl.x86_64: W: invalid-license GPL genders-perl.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.so Libgenders.so()(64bit) genders-perl.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.so Libgenders.so()(64bit) genders-perl.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.bs genders-perl.x86_64: W: hidden-file-or-dir /usr/lib64/perl5/vendor_perl/auto/Libgenders/.packlist genders-perl.x86_64: W: perl-temp-file /usr/lib64/perl5/vendor_perl/auto/Libgenders/.packlist genders-perl.x86_64: E: non-standard-executable-perm /usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.so 0555L genders-python.x86_64: W: summary-not-capitalized C python libraries genders-python.x86_64: E: no-changelogname-tag genders-python.x86_64: W: invalid-license GPL genders-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libgenders.so libgenders.so()(64bit) genders-python.x86_64: W: no-documentation libgenders.x86_64: W: summary-not-capitalized C genders libraries libgenders.x86_64: E: no-changelogname-tag libgenders.x86_64: W: invalid-license GPL libgenders.x86_64: W: shared-lib-calls-exit /usr/lib64/libgenders.so.0.3.0 exit@GLIBC_2.2.5 libgenders.x86_64: E: library-without-ldconfig-postin /usr/lib64/libgenders.so.0.3.0 libgenders.x86_64: E: library-without-ldconfig-postun /usr/lib64/libgenders.so.0.3.0 libgenders-devel.x86_64: W: no-dependency-on libgenders/libgenders-libs/liblibgenders libgenders-devel.x86_64: W: summary-not-capitalized C genders development libraries libgenders-devel.x86_64: W: non-standard-group System Environment/Development libgenders-devel.x86_64: E: no-changelogname-tag libgenders-devel.x86_64: W: invalid-license GPL libgendersplusplus.x86_64: W: summary-not-capitalized C genders libraries libgendersplusplus.x86_64: E: no-changelogname-tag libgendersplusplus.x86_64: W: invalid-license GPL libgendersplusplus.x86_64: W: invalid-url URL: http://genders.sf.net <urlopen error [Errno 104] Connection reset by peer> libgendersplusplus.x86_64: W: no-documentation libgendersplusplus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libgendersplusplus.so.1.0.0 libgendersplusplus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libgendersplusplus.so.1.0.0 libgendersplusplus-devel.x86_64: W: no-dependency-on libgendersplusplus/libgendersplusplus-libs/liblibgendersplusplus libgendersplusplus-devel.x86_64: W: summary-not-capitalized C genders development libraries libgendersplusplus-devel.x86_64: W: non-standard-group System Environment/Development libgendersplusplus-devel.x86_64: E: no-changelogname-tag libgendersplusplus-devel.x86_64: W: invalid-license GPL libgendersplusplus-devel.x86_64: W: no-documentation genders-debuginfo.x86_64: E: no-changelogname-tag genders-debuginfo.x86_64: W: invalid-license GPL 10 packages and 0 specfiles checked; 19 errors, 37 warnings. You can look, what those errors/warnings mean with "rpmlint -I", e.g.: $ rpmlint -I library-without-ldconfig-postin library-without-ldconfig-postin: This package contains a library and provides no %post scriptlet containing a call to ldconfig. Solution to this is here: http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review