Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flex-old - Legacy version of flex, a tool for creating scanners https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220381 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-02-02 06:07 EST ------- These comments are based on http://people.redhat.com/~pmachata/compat-flex-2.5.4a-1.src.rpm # rpm -qlp compat-flex-2.5.4a-1.i386.rpm /usr/bin/flex++-2.5.4a /usr/bin/flex-2.5.4a /usr/include/flex-2.5.4a/FlexLexer.h /usr/lib/flex-2.5.4a/libfl.a /usr/share/doc/compat-flex-2.5.4a /usr/share/doc/compat-flex-2.5.4a/COPYING /usr/share/doc/compat-flex-2.5.4a/NEWS /usr/share/doc/compat-flex-2.5.4a/README /usr/share/info/flex-2.5.4a.info.gz /usr/share/man/man1/flex++-2.5.4a.1.gz /usr/share/man/man1/flex-2.5.4a.1.gz MUSTFIX: - Package must own /usr/lib/flex-2.5.4a /usr/include/flex-2.5.4a - BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root Please change this to the current FE conventions. CONSIDER - I think this package should contain a small README.fedora, which outlines what it is and how it is supposed to be used (mentioning -I/usr/include/flex-2.5.4a and -L/usr/lib/flex-2.5.4a) Please decide upon the final name of this package, update your srpm once more, add a corresponding URL here in bugzilla and, provided you address the issues mentioned here-in, I'd approve this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review