[Bug 790628] Review Request: Adobe Source Libraries - General Purpose Addon for Boost and STL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790628

--- Comment #19 from Jeremy Newton <alexjnewt@xxxxxxxxxxx> 2012-02-29 10:36:16 EST ---
I would suggest looking into the zero-length file to see what the purpose is
for this file; though if you're unable to find out upstream or else wise, it
might be best to ignore it.

(In reply to comment #17)
> - get-source.sh now removes everything besides the tools subdirectory from the
> bundled boost library.

Note that this is usually removed in %prep unless there is something legally
troubling with it. Although it isn't explicitly required and since it
dramatically reduces the size of the source, I would see it as acceptable.

> - jamroot is patched to not include other references to boost source.

Is this the asl-fedora-flags.patch or is it one of the sed/other lines? Not to
nit pick, but it doesn't seem very clear in the spec file, in the name of the
patch, or the comments.


Also, what is source2? It doesn't seem to be mentioned in the commenting

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]