Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790628 --- Comment #18 from Alec Leamas <leamas.alec@xxxxxxxxx> 2012-02-24 06:51:06 EST --- Updated after test with fedora-review tool: fedora-review -b 790628 --mock-config fedora-16-i386 Comments: [!]: MUST If (and only if) the source package includes the text of the license(s)... Seems like a tool error, LICENSE_1_0_0.txt is in docs as expected. [!]: SHOULD SourceX / PatchY prefixed with %{name} I have used the 'asl' prefix instead, to avoid insanely long names. E: zero-length /usr/share/doc/adobe-source-libraries-doc-1.0.43/documentation/performance/index.html Don't think this should cause any harm, whereas removing it possibly might screw up some links. Ergo leaving it as-is. W: strange-permission get-source.sh 0755L This is as intended, get-source is a script used to build %Source0 W: invalid-url Source0: adobe-source-libraries-1.0.43-1.47.0.tar.gz Properly commented in lines above (http://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs). W: no-documentation in devel package OK since it requires base package which has the docs. New Links: http://dl.dropbox.com/u/17870887/asl-5/adobe-source-libraries.spec http://dl.dropbox.com/u/17870887/asl-5/adobe-source-libraries-1.0.43-5.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review