Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798248 --- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> 2012-02-28 09:29:43 EST --- (In reply to comment #2) > * Test suite execution > - The test command you are using is somehow cryptic as well as the result is > not comprehensive. Is this really the best approach? Wouldn't be better to > fallback to rake in this particular case? I found out an easier way: RUBYOPT="-I../lib" ./test_env testrb *_test.rb t[0-9]*.rb I think that this is quite straightforward and I would really not like to get to rake. Would this be ok for you? > * Bundled libraries > - the lib/dbus/core_ext directory contains files copied from active support. > Not sure if we should replace them by dependency on AS. If not, the license > of the package should be adjusted at least. The best would be if upstream > will consider to remove this bundled files, but I can imagine it will > be hard :/ > I will investigate and try to discuss it with upstream. > * Rename > - The package should obsolete and provide "oldpackagename", however you are > obsoleting and providing virtual provide. Is that intentional? > Hmm, I am not sure and the guidelines [1] don't say anything about virtual provides. Maybe both package name and its virtual provides should be obsoleted? > Please fix the above mentioned issues before the package could be approved. > Thank you. When I solve points 2 and 3, I'll post new SPEC and SRPM. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review