Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798248 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-02-28 09:22:27 EST --- * Test suite execution - The test command you are using is somehow cryptic as well as the result is not comprehensive. Is this really the best approach? Wouldn't be better to fallback to rake in this particular case? * Bundled libraries - the lib/dbus/core_ext directory contains files copied from active support. Not sure if we should replace them by dependency on AS. If not, the license of the package should be adjusted at least. The best would be if upstream will consider to remove this bundled files, but I can imagine it will be hard :/ * Rename - The package should obsolete and provide "oldpackagename", however you are obsoleting and providing virtual provide. Is that intentional? Please fix the above mentioned issues before the package could be approved. Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review