Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783825 --- Comment #11 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2012-02-21 17:46:34 EST --- (In reply to comment #10) > Please remove the version constraints for qt-devel and gtk2-devel. qt-devel > will always be newer than 4.0; analogue gtk2. Fair enough. > > The author expresses a few specific wishes in PACKAGING. What do you think > about them? Do they make sense for Fedora? > > Especially having sub-packages for the different toolkits sounds appealing to > me. Why would you drag in Qt or GTK if you don't need it? But as far as I can > see, both libraries are linked to both toolkits at the moment. They are build requirements only. The whole point of the package is to enable linking plugins dynamically at runtime regardless of which toolkit they use. > > The wish for major version in package names makes sense, given the name of the > .so and when I look at where the header file goes: > > /usr/include/suil-0/suil/suil.h > > Please make {_mandir}/man3/%{name}.3.gz {_mandir}/man3/%{name}.3* in case the > compression method changes. OK > > Parts of the build don't use the optflags. > > " * Debuggable build : False" > > ... and rpmlint's ... > > suil-debuginfo.x86_64: E: debuginfo-without-sources > > ... indicate something is wrong. OK, new SRPM imminent -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review