[Bug 783825] Review Request: suil - A lightweight C library for loading and wrapping LV2 plugin UIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783825

--- Comment #10 from Volker Fröhlich <volker27@xxxxxx> 2012-02-21 17:03:23 EST ---
Please remove the version constraints for qt-devel and gtk2-devel. qt-devel
will always be newer than 4.0; analogue gtk2.

The author expresses a few specific wishes in PACKAGING. What do you think
about them? Do they make sense for Fedora?

Especially having sub-packages for the different toolkits sounds appealing to
me. Why would you drag in Qt or GTK if you don't need it? But as far as I can
see, both libraries are linked to both toolkits at the moment.

The wish for major version in package names makes sense, given the name of the
.so and when I look at where the header file goes:

/usr/include/suil-0/suil/suil.h

Please make {_mandir}/man3/%{name}.3.gz {_mandir}/man3/%{name}.3* in case the
compression method changes.

Parts of the build don't use the optflags.

" * Debuggable build                                      : False"

... and rpmlint's ...

  suil-debuginfo.x86_64: E: debuginfo-without-sources

... indicate something is wrong.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]