Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785448 d. johnson <drjohnson1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |drjohnson1@xxxxxxxxx Bug 785448 depends on bug 785424, which changed state. Bug 785424 Summary: Review Request: php-channel-horde - Adds pear.horde.org channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=785424 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Status|MODIFIED |ON_QA Resolution| |ERRATA Status|ON_QA |CLOSED --- Comment #1 from d. johnson <drjohnson1@xxxxxxxxx> 2012-02-18 23:15:37 EST --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x] Package meets naming and packaging guidelines [x] Spec file matches base package name. [x] Spec has consistant macro usage. [x] Meets Packaging Guidelines. [x] License [1] License field in spec matches [ ] License file included in package [x] Spec in American English [x] Spec is legible. [x] Sources match upstream md5sum: 98dc26117c17996b257bc14a05a4efc3 Horde_Autoloader-1.0.1.tgz 98dc26117c17996b257bc14a05a4efc3 Horde_Autoloader-1.0.1.tgz.orig [-] Package needs ExcludeArch [x] BuildRequires correct [x] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [2] Package has %defattr and permissions on files is good. [3] Package has a correct %clean section. [-] Package has correct buildroot (el) %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is code or permissible content. [-] Doc subpackage needed/used. [x] Packages %doc files don't affect runtime. [-] Headers/static libs in -devel subpackage. [-] Spec has needed ldconfig in post and postun [-] .pc files in -devel subpackage/requires pkgconfig [-] .so files in -devel subpackage. [-] -devel package Requires: %{name} = %{version}-%{release} [-] .la files are removed. [-] Package is a GUI app and has a .desktop file [x] Package compiles and builds on at least one arch. [x] Package has no duplicate files in %files. [x] Package doesn't own any directories other packages own. [x] Package owns all the directories it creates. [x] No rpmlint output. % rpmlint *rpm php-horde-Horde-Autoloader*spec php-horde-Horde-Autoloader.noarch: W: spelling-error %description -l en_US Autoload -> Auto load, Auto-load, Tautology php-horde-Horde-Autoloader.src: W: spelling-error %description -l en_US Autoload -> Auto load, Auto-load, Tautology 2 packages and 1 specfiles checked; 0 errors, 2 warnings. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) php-pear(pear.horde.org/Horde_Autoloader) = 1.0.1 php-horde-Horde-Autoloader = 1.0.1-1.fc16 SHOULD Items: [x] Should build in mock. [x] Should build on all supported archs [x] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [x] Should have dist tag [x] Should package latest version [-] check for outstanding bugs on package. (For core merge reviews) Issues: 1. License on source page says LGPL-2.1, spec says LGPLv2+ 2. no %defattr (optional for fedora, needed for el5) 3. no %clean (optional for fedora, needed for el5) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review