Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790628 David Timms <dtimms@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dtimms@xxxxxxxxxxxx --- Comment #12 from David Timms <dtimms@xxxxxxxxxxxx> 2012-02-18 22:13:52 EST --- (In reply to comment #9) > http://dl.dropbox.com/u/17870887/adobe-3/adobe-source-libraries.spec Just some basic questions/comments: 1. The source download pointed to by the web page is a sf download. You would usually use a full URL for the Source0. Fedora uses a specific fixed URL to access sf sources, see: https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net Unless you are packaging direct from version control, and if so, should state why, and the Release: would need work to fit with one of Fedora's pre/post release naming schemes, see: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages 2. Where possible, provide comment info on Source1,2. eg: exact URL retrieved from (in that case, why not use the url directly ?), or where it came from ? 3. In your changelog, please use a blank line to separate each dated entry. 4. Don't use large amount of white space between changelog date, email, and version parts. 5. Changelog version: don't include {?dist} ie: .fc15, see: https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs "must item" 6. Don't have you editor write config items to the spec file. (expandtab etc). 7. Static libs: see: https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries This looked promising regarding bjam and shared libraries: http://stackoverflow.com/questions/1768943/building-boost-on-linux-library-names Might be worth looking to see if another rpm based distro solved this already, eg Mandriva, Suse etc., or hints from debian based distro. 8. tools/bjam: is this tool already in fedora ? If so, then BuildRequire it instead. These items are more technical; I haven't tried to build or analyse the prep / build commands. ps. I'm not a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review