Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=791263 --- Comment #6 from Roman Kennke <rkennke@xxxxxxxxxx> 2012-02-17 07:15:57 EST --- (In reply to comment #5) > Just a few quick comments for now: > (In reply to comment #4) > > Ok, I now did the additional changes: > > Please always bump the release and add a changelog entry what you did. This way > you also get a new SRPM (with other relase), so anyone can run a diff, who > wants to. Ok thanks for the hint. Will do so for any future changes. > > - Created source tarball myself by checking out the upstream sourcecode, > > updating to release tag 1.9.0, stripping out bundled dependency JARs and a > > bunch of questionable fluff, converting line endings to Unix > > How? :) There needs to be a full URL where you download the source or describe > in a comment in the spec file, how you did it (not like a comment like here, > bash what you did). I made a small shell script. Should I include it in the package or what is the preferred way of distributing it? > > Files in same location as above. > > It would be best to always putt the URL again here, so nobody needs to search > again, furthermore the link will change slightly, when you bump the release ;) Ok, will do so for any future changes (I actually might setup a VCS just for the specfile, patches, and the script). Spec URL: http://icedrobot.de/~roman/mockito.spec SRPM URL: http://icedrobot.de/~roman/mockito-1.9.0-1.fc16.src.rpm Thanks, Roman -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review