Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=791263 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #5 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2012-02-17 07:03:10 EST --- Just a few quick comments for now: (In reply to comment #4) > Ok, I now did the additional changes: Please always bump the release and add a changelog entry what you did. This way you also get a new SRPM (with other relase), so anyone can run a diff, who wants to. > - Created source tarball myself by checking out the upstream sourcecode, > updating to release tag 1.9.0, stripping out bundled dependency JARs and a > bunch of questionable fluff, converting line endings to Unix How? :) There needs to be a full URL where you download the source or describe in a comment in the spec file, how you did it (not like a comment like here, bash what you did). > Files in same location as above. It would be best to always putt the URL again here, so nobody needs to search again, furthermore the link will change slightly, when you bump the release ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review