Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783683 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> 2012-02-14 13:47:15 EST --- Is the flex BR really necessary? I don't see flex being invoked during the build. +: OK -: must be fixed =: should be fixed (at your discretion) N: not applicable MUST: [+] rpmlint output: cptutils.x86_64: W: spelling-error %description -l en_US ggr -> gr, gar, mgr cptutils.x86_64: W: spelling-error %description -l en_US cpt -> pct, cot, ct cptutils.x86_64: W: spelling-error %description -l en_US avl -> val, av, lav cptutils.x86_64: W: spelling-error %description -l en_US lut -> loot, ult, lit cptutils.x86_64: W: spelling-error %description -l en_US xmedcon -> consumed cptutils.x86_64: W: spelling-error %description -l en_US svg -> avg, sag, VG cptutils.x86_64: W: spelling-error %description -l en_US grd -> gr, rd, grid 1 packages and 1 specfiles checked; 0 errors, 7 warnings. Those are all innocuous. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license [+] license field matches the actual license [+] license file is included in %doc [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum is 46a1e1a22e75c84514b6515f3ccad1d8 for both [+] package builds on at least one primary arch (tried x86_64) [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires: [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [N] query upstream for license text [N] description and summary contain available translations [+] package builds in mock: tried fedora-rawhide-i386 [+] package builds on all supported arches: tried i386 and x86_64 [+] package functions as described: light testing only [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [N] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts If the flex BR isn't necessary, please remove it. Otherwise, this package looks great. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review