Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787364 --- Comment #6 from Pierre Dorbais <pierre.dorbais@xxxxxxx> 2012-02-14 13:48:14 EST --- (In reply to comment #3) > According to the code, license is GPLv3+. > > Throw away the defattr line, it is not necessary. "rm -rf $RPM_BUILD_ROOT" is > outdated too. > > Should that really be "plate-forms" and not "platform"? > > As you're not defining or using MIME types, neither installing icons in the > hicolor directory, all of the scriptlets are useless. > > Please preserve the timestamps when installing, where it makes sense. For > instance, use cp -p icon.png ... > > Commonly _datadir is used instead of _datarootdir. > > Please use the name macro consistently. OK, fixed (In reply to comment #4) > I can't find your name in the packagers group. Do you have a sponsor yet? If > not, please follow point 3: > > http://fedoraproject.org/wiki/Package_Review_Process Strangely I'm not in Packagers groups (my screenname is chdorb) however my sponsor is mtasaka and I've already created two packages (ciso and vifm). I don't understand... ------ [chdorb@chdorb-desktop rpmbuild]$ rpmlint SPECS/clipgrab.spec RPMS/i686/clipgrab-3.1.3.0-2.fc16.i686.rpm RPMS/i686/clipgrab-debuginfo-3.1.3.0-2.fc16.i686.rpm SRPMS/clipgrab-3.1.3.0-2.fc16.src.rpm clipgrab.i686: W: no-manual-page-for-binary clipgrab 3 packages and 1 specfiles checked; 0 errors, 1 warnings. Spec URL: http://pierre.dorbais.free.fr/rpms/clipgrab.spec SRPM URL: http://pierre.dorbais.free.fr/rpms/clipgrab-3.1.3.0-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review