[Bug 784950] Review Request: ktp-contact-applet - Telepathy contact plasmoid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784950

--- Comment #18 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2012-02-09 09:29:01 EST ---
(In reply to comment #17)
> Now, as to the contentions as to the thoroughness of the review here.  Yes, it
> was probably a bit too brief.  Let me suggest that instead of pointing out
> where the review is lacking (and being negative), focus on how to make *this*
> review better.  For example, if you see something in the proposed package
> that's missing or needs improvement, please do mention that.

I think the only way, why the topic went off-topic here is, that Matthias
wanted to have a bit more explicit review output, and nucleo considered it as
some finer pointing to "ban" him (That would be his sponsor's decision).
A simple "will do next time" would be enough.

> I'd argue any comment here that doesn't directly pertain to improving the
> quality of the package under review here, is in the least a bit off-topic, and
> at most, wasted and misdirected energy.

+0.5
Pointing out what could be made better (in a polite/'be excellent' way) can
also help other (future) reviews.


(In reply to comment #17)
> re: comment #14
> I've seen spectool -g fail before, but that's largely exposing bugs in the
> tool(s) it uses to download.  Put the URL into a browser, and it works.

Works == another click needed to finally download the source. ?
Was spectool ever working with such URLs?
I prefer "some URL" that works with wget or something like that, so you can
automate it. A slow proper upstream server instead of a mirror would be best in
this case.

e.g. A year ago, there was a script running to verify if all packages contain
the upstream sources or a modified version of it. I think, there should be a
URL that works with such a script.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]