Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=782560 --- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> 2012-02-07 07:07:57 EST --- - You don't need the macro definitions, as they are already defined in file macros.rubygems included in rubygems-devel package, that you are requiring in build time. - shadow.so file should be placed under %gem_extdir, see [1] for instructions on how to use it. - You need to obsolete the ruby-shadow package properly. According to [2], you should have: Provides: ruby(shadow) = %{version}-%{release} Obsoletes: ruby(shadow) < 2.1.1-1 - Could you please clarify the license? Your spec says its GPLv2+ or Ruby, the readme says it's "Free for any use with your own risk!", which is probably Public Domain, but you should query the author to state it clearly. - You don't need to BR: ruby(rubygems), since it gets drawn in by rubygems-devel. - %{gem_dir}/specifications/%{gem_name}-%{version}.gemspec can be replaced by %{gem_spec}. - %{gem_dir}/doc/%{gem_name}-%{version} can be replaced by %{gem_docdir}. - %{gem_instdir}/lib can be replaced by %{gem_libdir} [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby#RubyGem_with_extension_libraries_written_in_C [2] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review