Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772608 --- Comment #4 from Gal Hammer <ghammer@xxxxxxxxxx> 2012-01-25 03:12:36 EST --- (In reply to comment #3) > - In the Requires and BuildRequires statements some use %define macros for the > version and some hardcode them. It would probably be best to choose one method > of specifying the versions and use it consistently. The %define macros were copied from the gdm.spec file. I moved them closer to the GDM's BuildRequires section to separate them from the guest's BuildRequires section. > - The Source0 line is expected to contain a URL pointing to the archive or, > where applicable, just the name of the archive accompanied by a comment > explaining where it was generated from: > > http://fedoraproject.org/wiki/Packaging/SourceURL Fixed. > - Given the ExclusiveArch directive I am not sure this macro is required?: > > %ifnarch s390 s390x ppc64 > BuildRequires: xorg-x11-server-Xorg > %endif It is just a left over from the GDM's spec file. I removed it. > - There are a few spelling errors in the description, as well as mixed use of > tabs/spaces, detected by rpmlint. Fixed. Spec URL: http://ghammer.fedorapeople.org/ovirt-guest-agent.spec SRPM URL: http://ghammer.fedorapeople.org/ovirt-guest-agent-1.0.0-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review