Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772608 Stephen Gordon <sgordon@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sgordon@xxxxxxxxxx --- Comment #3 from Stephen Gordon <sgordon@xxxxxxxxxx> 2012-01-24 16:57:18 EST --- - In the Requires and BuildRequires statements some use %define macros for the version and some hardcode them. It would probably be best to choose one method of specifying the versions and use it consistently. - The Source0 line is expected to contain a URL pointing to the archive or, where applicable, just the name of the archive accompanied by a comment explaining where it was generated from: http://fedoraproject.org/wiki/Packaging/SourceURL - Given the ExclusiveArch directive I am not sure this macro is required?: %ifnarch s390 s390x ppc64 BuildRequires: xorg-x11-server-Xorg %endif - There are a few spelling errors in the description, as well as mixed use of tabs/spaces, detected by rpmlint. Output of rpmlint on the SRPM (given oVirt is the project name I think it is probably fair to ignore the first warning): ovirt-guest-agent.src: W: summary-not-capitalized C oVirt Guest Agent ovirt-guest-agent.src: W: spelling-error %description -l en_US managment -> management, engagement, Mantegna ovirt-guest-agent.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment ovirt-guest-agent.src:185: W: mixed-use-of-spaces-and-tabs (spaces: line 185, tab: line 180) ovirt-guest-agent.src: W: invalid-url Source0: ovirt-guest-agent-1.0.0.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 5 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review