Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693126 --- Comment #3 from Michal Ambroz <rebus@xxxxxxxxx> 2012-01-24 04:17:10 EST --- Hi Siem, thank you for your remarks. Sorry for delay. The core openvas-libraries, openvas-scanner, openvas-manager finally got to some usable state so I can follow-up on the rest of the packages. SPEC: http://rebus.fedorapeople.org/SPECS/openvas-administrator.spec SRPM: http://rebus.fedorapeople.org/SRPMS/openvas-administrator-1.1.2-1.fc16.src.rpm (In reply to comment #2) > - rpmbuild failed: > extend the Buildrequires with gcc and xmltoman Added buildrequires on xmltoman. Dependency to gcc is not needed. Here are logs from koji scratch build for F17 http://koji.fedoraproject.org/koji/taskinfo?taskID=3728246 > - you do not need a %clean script: I actually plan this package for EPEL as well and clean is needed there. > - systemd is required for init-scripts for Fedora 15+: Yes you are right. I have got reason for that - rest of the suite (openvas-scanner, openvas-manager) is still using systemv. As I target for EPEL I would preffer to finish the whole suite first with systemV style init scripts to have it prepared and tested for EPEL. Then I would like to move all to systemd. > - sqlite-devel is not required for building removed. It was copy paste from other openvas package. > - why do you require file /usr/bin/xsltproc and not the rpm libxslt it is > contained in? The rpmlint complained with error about the explicit dependency on libxslt while it is gracefull about having explicit dependency on file. From this I believed it is preferred way. I have changed it to require libxslt. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review