Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784047 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-24 04:15:28 EST --- Source file is original. Ok. URL and Source0 are alive. Ok. Summary verified from lib/HTTP/ProxyAutoConfig.pm. Ok. FIX: Change license to `GPLv2+ or Artistic' or clarify with upstream. lib/HTTP/ProxyAutoConfig.pm says: > This module is free software; you may redistribute it and/or modify it > under the same terms as Perl 5.10.1. For more details, see the full > text of the licenses at > <http://www.perlfoundation.org/artistic_license_1_0> and > http://www.gnu.org/licenses/gpl-2.0.html > <http://www.gnu.org/licenses/gpl-2.0.html> Description verified from lib/HTTP/ProxyAutoConfig.pm. Ok. All tests require network access witch is not available in Koji. Conditionally disabled by default Ok. $ rpmlint perl-HTTP-ProxyAutoConfig.spec ../SRPMS/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.src.rpm ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.src: W: spelling-error %description -l en_US pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error %description -l en_US pac -> PAC, cap, pa 2 packages and 1 specfiles checked; 0 errors, 8 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm drwxr-xr-x 2 root root 0 Jan 24 09:57 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3 -rw-r--r-- 1 root root 1257 Mar 26 2010 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/Changes -rw-r--r-- 1 root root 2382 Mar 14 2010 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/README drwxr-xr-x 2 root root 0 Jan 24 09:57 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/examples -rwxr-xr-x 1 root root 284 May 25 2001 /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/examples/auto_proxy.pl -rw-r--r-- 1 root root 3440 Jan 24 09:57 /usr/share/man/man3/HTTP::ProxyAutoConfig.3pm.gz drwxr-xr-x 2 root root 0 Jan 24 09:57 /usr/share/perl5/vendor_perl/HTTP -rw-r--r-- 1 root root 23760 Mar 26 2010 /usr/share/perl5/vendor_perl/HTTP/ProxyAutoConfig.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(IO::Socket) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(Sys::Hostname) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Documentation does not push new dependencies. Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm | sort | uniq -c 1 perl(HTTP::ProxyAutoConfig) = 0.3 1 perl-HTTP-ProxyAutoConfig = 0.3-1.fc17 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3728249). ??? Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review