Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721179 --- Comment #30 from Shawn Starr <shawn.starr@xxxxxxxxxx> 2012-01-03 13:24:01 EST --- Good idea on rpmlint for .spec file itself: 1) Fixed noise in comments 2) Removed sitearch macro altogether, this rubygem has no DSOs 3) Replace SOURCE0 URL with new location - URL also is valid. 4) Don't delete VERSION and keep it with the package for consistency mark as a %doc file -> /usr/lib/ruby/gems/1.8/gems/extlib-0.9.15/VERSION Spec URL: http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib.spec SRPM URL: http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib-0.9.15-3.fc17.src.rpm rpmlint: PASS (with usual ruby doc warnings) RPMs rpmlint: PASS .spec file mock build: PASS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review