[Bug 721179] Review Request: rubygem-extlib - Support library for DataMapper and Merb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721179

--- Comment #29 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-01-03 06:57:29 EST ---
Hi Shawn,

* There is still unnecessary noise in rpmlint ouput:

./rubygem-extlib.spec:2: W: macro-in-comment %global
./rubygem-extlib.spec:2: W: macro-in-comment %(ruby
./rubygem-extlib.spec:81: W: macro-in-comment %exclude
./rubygem-extlib.spec:81: W: macro-in-comment %{geminstdir}
./rubygem-extlib.spec:91: W: macro-in-comment %exclude
./rubygem-extlib.spec:91: W: macro-in-comment %{geminstdir}
rubygem-extlib.src: W: strange-permission extlib-0.9.15.gem 0666L

* I am not sure why are still defining the ruby_sitearch macro. I would suggest
to remove lines 2-3 (sed '2,3d' rubygem-extlib.spec). Note that this would fix
also one of the rpmlint complaints.

* The Source0 URL is obsolete. You should use
"http://rubygems.org/gems/%{gemname}-%{version}.gem"; instead.

* Be careful with the VERSION file. Some gems may require it for proper
functionality. Nevertheless in this case, it is not mandatory, so not and
issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]