Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523877 --- Comment #40 from Tim Fenn <tim.fenn@xxxxxxxxx> 2011-12-30 18:56:34 EST --- Sorry for my late reply, holidays and what not. (In reply to comment #39) > 1) Are you sure that doc is under GPL2 (%files section, -devel)? Yes - this was discussed with upstream in Sept. 2009 (!) - all the API calls are LGPLv2+, all else is GPLv2+. > 2) Two adscimg2cbf in %files fixed > 3) You still wants utils (which are from examples btw) in main CBF_lib_ package > but not to do CBFlib-utils subpackage. Just tell me you realy insist on it. see comments 12-16 (unless something changed recently?) > 4) cbf.c contain two exit calls (both are memory allocation error) that going > to shared library. Could it be easy handled? I suppose "no" but still. It is > not a blocker. I'll mention this to upstream and suggest some ideas and try to get this handled by the author(s). > 5) Typo in %changelog: first string contain "0.9.2.1-1" but not "0.9.2.2-1". fixed > 6) Please use %{optflags} and %{buildroot}. done > 7) gpl.txt is to be in doc dir. Do not move it, you could copy it if you want > it in root. (%doc doc/gpl.txt will work) fixed http://sites.google.com/site/timfenn/CBFlib.spec http://sites.google.com/site/timfenn/CBFlib-0.9.2.3-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review