Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523877 --- Comment #39 from Dmitrij S. Kryzhevich <krege@xxxxxxx> 2011-12-21 23:44:26 EST --- 1) Are you sure that doc is under GPL2 (%files section, -devel)? 2) Two adscimg2cbf in %files 3) You still wants utils (which are from examples btw) in main CBF_lib_ package but not to do CBFlib-utils subpackage. Just tell me you realy insist on it. 4) cbf.c contain two exit calls (both are memory allocation error) that going to shared library. Could it be easy handled? I suppose "no" but still. It is not a blocker. 5) Typo in %changelog: first string contain "0.9.2.1-1" but not "0.9.2.2-1". 6) Please use %{optflags} and %{buildroot}. 7) gpl.txt is to be in doc dir. Do not move it, you could copy it if you want it in root. (%doc doc/gpl.txt will work) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review