Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769958 --- Comment #2 from John C Peterson <jcp@xxxxxxxxxx> 2011-12-23 16:34:20 EST --- Spec URL: http://www.eskimo.com/~jcp/eqp.spec SRPM URL: http://www.eskimo.com/~jcp/eqp-09e-2.fc16.src.rpm Jerry - thanks again for sponsoring me. I think I have fixed all of the minor issues you have raised. As you suggested, I just eliminated the patch to the Makefile and made the corresponding adjustments to the make command in the %build section. The "go" script in the examples sub-directory is rather trivial as you can see by inspection, so it really doesn't warrant an examples sub-package. I elected to just remove the executable permission bits. It could also be entirely eliminated from the package if that is in some way preferable. I eliminated the checks in %install and %clean for RPM_BUILD_ROOT being equal to "/" as you suggested. Just the thought of that happening is enough to make my hair stand on end, so I have included it in all my personal packages for ages now. (I guess I am dating myself by including that :^) Your patch for the printf statements is a much better solution than mine, and as you said, it also works independent of the host architecture. The issues relating to the licensing are a valid concern of course, but could be a show stopper in this case because there is no upstream to contact regarding this issue (or the filing of bug reports). The author, William McCune, passed away rather suddenly back in May 2011. A shocker to the ATP community for sure as he was only 58! http://www.cs.unm.edu/~veroff/ADAM/2011/ I will contact fedora-legal-list@xxxxxxxxxx as you suggested. It's worth a try. I doubt that it would be of any help in making a legal clarification, but Bill was also the author of Prover9/Mace which is already packaged in Fedora as prover9. That package is licensed under GPLv2 and GPLv2+, but the prover9 source distribution includes a file named COPYING that clearly states that, which is not the case for EQP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review