Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> 2011-12-22 10:54:13 EST --- (In reply to comment #5) > Indeed. I meant to say this in my mysterious "This is way I didn't split > produce a separate -debug package" sentence in comment 0 as well. (Apparently > my command of the English language comes and goes ..) Heh. I'd say your command of English is quite good. It's certainly far better than my command of Mandarin Chinese, which I used to speak (but not read or write) semi-fluently 20-some years ago. Today I have trouble putting a coherent sentence together. > I used hyphens because that's what Debian did: Good enough. Thanks for the explanation. And I screwed up on some of the pluses and minuses. Sorry about that. This is what happens when I cut & paste from a template. I'm going to make the template have nothing in between the brackets so I'm forced to think about the contents of every single one in the future. Let me draw your attention to 2 more items, with the correct character between the brackets this time: MUST: [=] package meets the packaging guidelines: but consider adding "-p" to the "cp" invocations, as per https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps. [-] license field matches the actual license: not quite. The LICENSE file mentions exceptions, so the license should be "LGPLv2+ with exceptions". Also, some of the examples are GPLv2+ (e.g., examples/graph_viewer/scene.mli), and one is WTFPL (examples/boulderdash/boulderdash.ml). I think the -doc subpackage will need to have a license along the lines of "(LGPLv2+ with exceptions) and GPLv2+ and WTFPL". Everything else looks fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review