Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #5 from Scott Tsai <scottt.tw@xxxxxxxxx> 2011-12-21 16:20:20 EST --- (In reply to comment #3) > I assume the devel-file-in-non-devel-package warnings are because those devel > files are needed in the translation process. Is that right? Indeed. I meant to say this in my mysterious "This is way I didn't split produce a separate -debug package" sentence in comment 0 as well. (Apparently my command of the English language comes and goes ..) > [=] follows package naming guidelines: why did you change the underscores to hyphens? I used hyphens because that's what Debian did: http://packages.debian.org/sid/js-of-ocaml Say you're trying to build some upstream open source project and the upstream website says "Run apt-get ... to install the build dependencies". I run into this often enough that I'd like to keep the package name consistent with Debian unless there's a strong reason not to. > [-] package functions as described: only minimal testing The bundled examples are built so the OCaml to Javascript compiler is minimally tested. I can't run the generated code since they are interactive programs that assumes a user clicking in a browser. I have personally built a large non trivial program and ran it successfully with this js-of-ocaml package though: http://blog.scottt.tw/2011/12/compiling-web-interface-of-ppcmemarmmem.html I can see how collecting simple OCaml programs and running the generated code with a command line Javascript interpreter like /usr/bin/js could work but lack the motivation to do that since upstream didn't. > [=] package contains man pages for binaries/scripts Upstream didn't include a man page. I can't find one I can conveniently steal from other distros so I punted here as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review