Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768800 --- Comment #3 from Peter Hutterer <peter.hutterer@xxxxxxxxxx> 2011-12-21 21:46:24 EST --- (In reply to comment #2) > packaging guidelines: generally, ok. some minor cleanups possible: > - BuildRoot: is no longer needed > - rm -rf %{buildroot} in %install no longer needed > - %clean no longer needed all three removed > directory ownership: looks like you need to own > %{_datadir}/libwacom > %{_includedir}/libwacom-1.0 > %{_includedir}/libwacom-1.0/libwacom added to the devel/data packages as required. update spec/srpm available at URL above -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review