Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768800 --- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2011-12-21 10:51:43 EST --- package name: ok spec file name: ok packaging guidelines: generally, ok. some minor cleanups possible: - BuildRoot: is no longer needed - rm -rf %{buildroot} in %install no longer needed - %clean no longer needed fine to leave these things in place if you want to minimize spec file changes for building on e.g. RHEL license: ok license: field ok license file: ok spec language: ok spec readable: ok upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libs: ok relocatable: ok directory ownership: looks like you need to own %{_datadir}/libwacom %{_includedir}/libwacom-1.0 %{_includedir}/libwacom-1.0/libwacom duplicate files: ok file permissions: ok macro use: ok content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel dep: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok Summary: fix directory ownership, then it is good to go -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review