Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693370 --- Comment #11 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2011-12-17 09:18:06 EST --- REVIEW FOR e99fff15202db7198f75853065b0130a elementary-2.1-3.fc15.src.rpm MUST items FIX - MUST: rpmlint output: elementary.src: W: name-repeated-in-summary C Elementary elementary.src: W: no-%build-section elementary-gnome-theme.noarch: W: spelling-error %description -l en_US metacity -> meta city, meta-city, mendacity elementary-gnome-theme.noarch: E: description-line-too-long C Desktop theme for GNOME, includes elementary icon theme and elementary metacity (window manager). elementary-gnome-theme.noarch: W: no-documentation elementary-gtk-theme.noarch: W: no-documentation elementary-gtk-theme.noarch: E: backup-file-in-package /usr/share/themes/elementary/gtk-2.0/Apps/panel.rc.~1~ elementary-gtk-theme.noarch: E: backup-file-in-package /usr/share/themes/elementary/gtk-2.0/Apps/postler.rc.~1~ elementary-gtk-theme.noarch: E: backup-file-in-package /usr/share/themes/elementary/gtk-2.0/gtkrc.~1~ elementary-gtk-theme.noarch: E: backup-file-in-package /usr/share/themes/elementary/gtk-2.0/Apps/panel-dark.rc.~1~ elementary-metacity-theme.noarch: W: no-documentation elementary-xfwm4-theme.noarch: W: no-documentation 5 packages and 0 specfiles checked; 5 errors, 7 warnings. - Consider adding an empty %build to fix the no-%build-section warning - Ignore spelling-error warnings - make sure to insert line breaks after 79 characters to get rid of the description-line-too-long error - remove backup files (you could to this in %build, then it has at least a purpose ;) ) - include documentation. The rule of thumb is AUTHORS, CONTRIBUTORS and COPYING and need to be installed for every independent package. You can skip them if they are already installed through a dependency. OK - MUST: package is named according to the Package Naming Guidelines, but I'd rather prefer the package to be named elementary-theme OK - MUST: spec file name matches the base package in the format %{name}.spec FIX - MUST: package meets the Packaging Guidelines. Preserve the timestamps when using install or cp, see https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps OK - MUST: package is licensed with a Fedora approved license and meets the Licensing Guidelines: GPLv2 FIX - MUST: License field in the package spec file does not match the actual license. According to the AUTHORS file this it's GPLv2 (only), not "or any later version". FIX - MUST: source package includes the text of the license in its own file and that file is included in %doc OK - MUST: spec file is written in American English OK - MUST: spec file for the package is legible OK - MUST: sources match the upstream source, as provided in the spec URL by md5 f685d659c72271944ca2e76d638ca2ed OK - MUST: package successfully compiles and builds into binary rpms on at least one primary architecture N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch OK - MUST: all build dependencies are listed in BuildRequires N/A - MUST: spec file handles locales properly using %find_lang N/A - MUST: package (or subpackage) stores shared library files in the dynamic linker's default paths and call ldconfig in %post and %postun OK - MUST: package does not bundle copies of system libraries OK - MUST: package is not designed to be relocatable FIX - MUST: package owns all directories that it creates: You need to own %{_datadir}/themes/elementary or require a package that owns it. See https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership OK - MUST: package does not list a file more than once in the spec file's %files listings OK - MUST: permissions on files are set properly FIX - MUST: package does not use macros consistently. You are mixing two different styles, see https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS OK - MUST: package contains code, or permissable content N/A - MUST: large documentation files must go in a -doc subpackage OK - MUST: files included as %doc do not affect the runtime of the application N/A - MUST: header files are in -devel package N/A - MUST: static libraries are in -static package N/A - MUST: library files with a suffix are in -devel package N/A - MUST: -devel package requires the base package using a fully versioned dependency OK - MUST: package does not contain any .la libtool archives OK - MUST: package does not include a GUI application, no need for a %{name}.desktop file OK - MUST: package does not own files or directories already owned by other packages OK - MUST: all filenames in the package are valid UTF-8 SHOULD items N/A - SHOULD: source package does not include license text(s) as a separate file from upstream, query upstream to include it N/A - SHOULD: description and summary sections should contain translations for supported Non-English languages, if available OK - SHOULD: package builds in mock OK - SHOULD: package compiles and builds into binary rpms on all supported architectures OK - SHOULD: package functions as described N/A - SHOULD: scriptlets are sane N/A - SHOULD: subpackages other than devel require the base package using a fully versioned dependency N/A - SHOULD: pkgconfig(.pc) files are in -devel package OK - SHOULD: package has no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin N/A - SHOULD: package contains man pages for binaries/scripts OTHER items OK - latest stable version packaged OK - source URL valid N/A - compiler flags ok N/A - debuginfo complete OK - package has a %clean section, which contains rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). N/A - package contains a pkgconfig(.pc) files and has 'Requires: pkgconfig'. ISSUES - Fix rpmlint errors/warnings (see above) - Fix all items marked with FIX - Strictly speaking elementary-xfwm4-theme and elementary-metacity-theme don't need to require elementary-gtk-theme, but if you remove it from elementary-metacity-theme make sure to add a dependency in elementary-gnome-theme NOTES - Consider renaming spec and source package package to elementary-theme. This will make it easier for users when they file bugs because bugzilla uses the srpm name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review