[Bug 693370] Review Request: elementary-gtk-theme - elementary GTK theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693370

--- Comment #10 from Chris Smart <fedora@xxxxxxxxxxxxxxxxxxxx> 2011-11-26 22:59:07 EST ---
Hi Chris,

If I rename the package to elementary-theme, then I can't reference %{name} in
the rest of the file, because the resulting packages install to just
'elementary' and not 'elementary-theme'
(e.g./usr/share/themes/elementary/metacity-1/). Happy to do it, but just wanted
to check first.

I've changed the install command to standard cp -r for directories, rather than
going into each directory and listing every file. I guess I should be doing it
that way, in the mean time I figured I'd get your feedback on the other things.

The unowned file was because I had a trailing slash on gtk-*.0 under %files,
but gtk-3.0 is a softlink. Fixed.

Those are fixed in new SRPM, except for name change at this point. I have also
renamed the GNOME and Xfwv4 packages to match the naming convention for GTK and
Metacity

Spec URL: http://csmart.fedorapeople.org/elementary/elementary.spec
Patch URL: http://csmart.fedorapeople.org/elementary/elementary-fedora.patch
SRPM URL:
http://csmart.fedorapeople.org/elementary/elementary-2.1-3.fc15.src.rpm

Thanks,
-c

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]