[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656082

--- Comment #15 from Jerry James <loganjerry@xxxxxxxxx> 2011-12-14 15:34:30 EST ---
Created attachment 546876
  --> https://bugzilla.redhat.com/attachment.cgi?id=546876
Patch to fix the link

If you run rpmlint on the *installed* libcprops package, not the binary RPM,
then you'll see lots of warnings like this:

$ rpmlint libcprops libcprops-devel
...
libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0
SSL_free
libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0
SSL_CTX_free
libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0
X509_NAME_get_text_by_NID
libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0
pthread_detach
libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0
SSL_get_error
...
libcprops.x86_64: W: undefined-non-weak-symbol
/usr/lib64/libcp_dbms_postgres.so.0.0.0 cp_string_destroy
libcprops.x86_64: W: undefined-non-weak-symbol
/usr/lib64/libcp_dbms_postgres.so.0.0.0 cp_hash_int
libcprops.x86_64: W: undefined-non-weak-symbol
/usr/lib64/libcp_dbms_postgres.so.0.0.0 intdup
libcprops.x86_64: W: undefined-non-weak-symbol
/usr/lib64/libcp_dbms_postgres.so.0.0.0 cp_hash_compare_int
...
libcprops.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcp_dbms_postgres.so.0.0.0 /lib64/libdl.so.2
libcprops.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcp_dbms_postgres.so.0.0.0 /lib64/libpthread.so.0
libcprops.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcp_dbms_postgres.so.0.0.0 /usr/lib64/libssl.so.10


These warnings indicate the the shared libraries are not being linked properly.
 This patch fixes part of the problem.  To fix the rest, drop this into your
spec file, in between the %configure invocation and the make invocation:

sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' \
    -e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \
    -e 's|func_apped|func_append|' \
    -e 's|CC -shared|CC -shared -Wl,--as-needed|' \
    -i libtool

The first two expressions are from
https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath.  You didn't
have problems with rpath before, because libtool only sets the rpath if the
object being created is linked against something.  The third expression fixes
bug 759376.  Normally, you could fix the unused-direct-shlib-dependency
warnings by adding "-Wl,--as-needed" to LDFLAGS, but that doesn't work when
using libtool due to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=347650, 
The fourth expression is a cheap and dirty workaround for that problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]