Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #13 from Jerry James <loganjerry@xxxxxxxxx> 2011-12-14 13:44:06 EST --- Created attachment 546853 --> https://bugzilla.redhat.com/attachment.cgi?id=546853 Patch to support mysql builds This isn't a requirement, just a suggestion. If you add the attached patch as Patch0, add a %bcond_without for mysql, add this: %if %with mysql BuildRequires: mysql-devel %endif add %patch0 to %prep, and add this to the configure invocation: %{?with_mysql:--with-mysql-includes=%{_includedir}/mysql} \ %{?with_mysql:--with-mysql-libs=%{_libdir}/mysql} then it is possible to build with mysql support, too. It might also be worth poking upstream about using standard autoconf macros, like AC_CHECK_HEADERS and AC_CHECK_LIB so we don't have to patch their broken shell scripts. :-) Sorry, I use mysql a lot at work, so I wondered why support wasn't included. I'll stop being distracted now and get back to the review... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review